[SECURITY] Eloquent: use Model::setAttribute method instead of $this->$key #301
+2
−2
Conversation
|
Nice, yep this is good. Tempted to say build failed but that's damn github's fault :P |
|
Haha, thanks, I wouldn't have noticed (there should be an email notification if a build fails, gonna send Github an email about that). Should I make a new commit just to relaunch the build? -_- |
|
Nah stuff it. Github's API usually stuffs up around 20-30% of builds for my apps, just because of rate limiting. Taylor can see it has worked on 1 version of PHP an that the other one has hung :)
|
|
Alright, thanks. |
taylorotwell
added a commit
that referenced
this issue
Feb 12, 2013
[SECURITY] Eloquent: use Model::setAttribute method instead of $this->$key
|
Thanks |
joelharkes
pushed a commit
to joelharkes/framework_old
that referenced
this issue
Mar 7, 2019
Logo url fix
dbpolito
pushed a commit
to dbpolito/framework
that referenced
this issue
Oct 1, 2019
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If you validate your models' attributes in per model method like
User::setUsernameAttribute(), the validation won't even be done when theModel::fill()is called. This could lead to wrongly formatted data being inserted in your DB just fine if you haven't implemented domain checks on your database server.